Multiple calls to setHazelcastInstance on HazelcastInstanceAware

[neilstevenson]

On 3.12, when a HazelcastInstanceAware runnable is executed,
the setHazelcastInstance method is called more than once

Reproducer is attached to #15007

[JackPGreen]

This still seems to be a problem, take the following example:

import com.hazelcast.collection.*;
import com.hazelcast.config.*;
import com.hazelcast.core.*;

public class ListenerTest {
    public static void main(final String[] args) {
        HazelcastInstance instance = Hazelcast.newHazelcastInstance();

        String objectName = "my-list";

        instance.getConfig().addListConfig(new ListConfig(objectName)
                .addItemListenerConfig(new ItemListenerConfig().setImplementation(new MyItemListener<>())));

        instance.getList(objectName).add(1);

        instance.shutdown();
    }

    public static class MyItemListener<V> implements ItemListener<V>, HazelcastInstanceAware {
        @Override
        public void itemAdded(ItemEvent<V> item) {
        }

        @Override
        public void itemRemoved(ItemEvent<V> item) {
        }

        public void setHazelcastInstance(HazelcastInstance hazelcastInstance) {
            System.out.println("setHazelcastInstance called from:");
        
            for (StackTraceElement ste : Thread.currentThread().getStackTrace()) {
                System.out.println(ste);
            }
        }
    }
}

HazelcastInstanceAware.setHazelcastInstance(HazelcastInstance) is called three times.

setHazelcastInstance called from:
java.base/java.lang.Thread.getStackTrace(Thread.java:1610)
ListenerTest$MyItemListener.setHazelcastInstance(ListenerTest.java:33)
com.hazelcast.instance.impl.HazelcastManagedContext.initialize(HazelcastManagedContext.java:39)
com.hazelcast.internal.serialization.impl.compact.CompactStreamSerializer.read(CompactStreamSerializer.java:190)
com.hazelcast.internal.serialization.impl.compact.CompactStreamSerializer.read(CompactStreamSerializer.java:174)
com.hazelcast.internal.serialization.impl.StreamSerializerAdapter.read(StreamSerializerAdapter.java:44)
com.hazelcast.internal.serialization.impl.AbstractSerializationService.readObject(AbstractSerializationService.java:357)
com.hazelcast.internal.serialization.InternalSerializationService.readObject(InternalSerializationService.java:81)
com.hazelcast.internal.serialization.impl.ByteArrayObjectDataInput.readObject(ByteArrayObjectDataInput.java:600)
com.hazelcast.config.ListenerConfig.readData(ListenerConfig.java:162)
com.hazelcast.config.ItemListenerConfig.readData(ItemListenerConfig.java:114)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.readInternal(DataSerializableSerializer.java:167)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:113)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:1)
com.hazelcast.internal.serialization.impl.StreamSerializerAdapter.read(StreamSerializerAdapter.java:44)
com.hazelcast.internal.serialization.impl.AbstractSerializationService.readObject(AbstractSerializationService.java:357)
com.hazelcast.internal.serialization.InternalSerializationService.readObject(InternalSerializationService.java:81)
com.hazelcast.internal.serialization.impl.ByteArrayObjectDataInput.readObject(ByteArrayObjectDataInput.java:600)
com.hazelcast.internal.serialization.impl.SerializationUtil.readList(SerializationUtil.java:432)
com.hazelcast.internal.serialization.impl.SerializationUtil.readNullableList(SerializationUtil.java:398)
com.hazelcast.config.CollectionConfig.readData(CollectionConfig.java:323)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.readInternal(DataSerializableSerializer.java:167)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:113)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:1)
com.hazelcast.internal.serialization.impl.StreamSerializerAdapter.read(StreamSerializerAdapter.java:44)
com.hazelcast.internal.serialization.impl.AbstractSerializationService.toObject(AbstractSerializationService.java:271)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.cloneConfig(ClusterWideConfigurationService.java:278)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.broadcastConfigAsync(ClusterWideConfigurationService.java:255)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.broadcastConfigAsync(ClusterWideConfigurationService.java:241)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.broadcastConfig(ClusterWideConfigurationService.java:217)
com.hazelcast.internal.dynamicconfig.DynamicConfigurationAwareConfig.addListConfig(DynamicConfigurationAwareConfig.java:418)
ListenerTest.main(ListenerTest.java:12)

setHazelcastInstance called from:
java.base/java.lang.Thread.getStackTrace(Thread.java:1610)
ListenerTest$MyItemListener.setHazelcastInstance(ListenerTest.java:33)
com.hazelcast.instance.impl.HazelcastManagedContext.initialize(HazelcastManagedContext.java:39)
com.hazelcast.internal.serialization.impl.AbstractSerializationService.readObject(AbstractSerializationService.java:359)
com.hazelcast.internal.serialization.InternalSerializationService.readObject(InternalSerializationService.java:81)
com.hazelcast.internal.serialization.impl.ByteArrayObjectDataInput.readObject(ByteArrayObjectDataInput.java:600)
com.hazelcast.config.ListenerConfig.readData(ListenerConfig.java:162)
com.hazelcast.config.ItemListenerConfig.readData(ItemListenerConfig.java:114)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.readInternal(DataSerializableSerializer.java:167)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:113)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:1)
com.hazelcast.internal.serialization.impl.StreamSerializerAdapter.read(StreamSerializerAdapter.java:44)
com.hazelcast.internal.serialization.impl.AbstractSerializationService.readObject(AbstractSerializationService.java:357)
com.hazelcast.internal.serialization.InternalSerializationService.readObject(InternalSerializationService.java:81)
com.hazelcast.internal.serialization.impl.ByteArrayObjectDataInput.readObject(ByteArrayObjectDataInput.java:600)
com.hazelcast.internal.serialization.impl.SerializationUtil.readList(SerializationUtil.java:432)
com.hazelcast.internal.serialization.impl.SerializationUtil.readNullableList(SerializationUtil.java:398)
com.hazelcast.config.CollectionConfig.readData(CollectionConfig.java:323)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.readInternal(DataSerializableSerializer.java:167)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:113)
com.hazelcast.internal.serialization.impl.DataSerializableSerializer.read(DataSerializableSerializer.java:1)
com.hazelcast.internal.serialization.impl.StreamSerializerAdapter.read(StreamSerializerAdapter.java:44)
com.hazelcast.internal.serialization.impl.AbstractSerializationService.toObject(AbstractSerializationService.java:271)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.cloneConfig(ClusterWideConfigurationService.java:278)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.broadcastConfigAsync(ClusterWideConfigurationService.java:255)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.broadcastConfigAsync(ClusterWideConfigurationService.java:241)
com.hazelcast.internal.dynamicconfig.ClusterWideConfigurationService.broadcastConfig(ClusterWideConfigurationService.java:217)
com.hazelcast.internal.dynamicconfig.DynamicConfigurationAwareConfig.addListConfig(DynamicConfigurationAwareConfig.java:418)
ListenerTest.main(ListenerTest.java:12)

setHazelcastInstance called from:
java.base/java.lang.Thread.getStackTrace(Thread.java:1610)
ListenerTest$MyItemListener.setHazelcastInstance(ListenerTest.java:33)
com.hazelcast.collection.impl.collection.AbstractCollectionProxyImpl.initialize(AbstractCollectionProxyImpl.java:95)
com.hazelcast.spi.impl.proxyservice.impl.ProxyRegistry.doCreateProxy(ProxyRegistry.java:266)
com.hazelcast.spi.impl.proxyservice.impl.ProxyRegistry.createProxy(ProxyRegistry.java:235)
com.hazelcast.spi.impl.proxyservice.impl.ProxyRegistry.getOrCreateProxyFuture(ProxyRegistry.java:202)
com.hazelcast.spi.impl.proxyservice.impl.ProxyRegistry.getOrCreateProxy(ProxyRegistry.java:182)
com.hazelcast.spi.impl.proxyservice.impl.ProxyServiceImpl.getDistributedObject(ProxyServiceImpl.java:153)
com.hazelcast.instance.impl.HazelcastInstanceImpl.getDistributedObject(HazelcastInstanceImpl.java:365)
com.hazelcast.instance.impl.HazelcastInstanceImpl.getList(HazelcastInstanceImpl.java:219)
com.hazelcast.instance.impl.HazelcastInstanceProxy.getList(HazelcastInstanceProxy.java:126)
ListenerTest.main(ListenerTest.java:15)