Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMap.removeAll without index updates last access time and expiry time for all records #15515

Closed
iseebirdsfly opened this issue Sep 4, 2019 · 3 comments · Fixed by #15850
Closed

IMap.removeAll without index updates last access time and expiry time for all records #15515

iseebirdsfly opened this issue Sep 4, 2019 · 3 comments · Fixed by #15850
Assignees
@vbekiaris
Labels
Module: IMap Source: Community PR or issue was opened by a community user Team: Core Type: Defect
Milestone
3.12.5

Comments

@iseebirdsfly
Copy link

Calling IMap.removeAll without index updates last access time for all records. As a result expiration time is also updated when maxIdle eviction is used. If removeAll is called frequently then records are never removed by maxIdle.
Hazelcast version: 3.12.2
Attached unit test demonstrating this behaviour.

IMapRemoveAllTest.java.zip
@iseebirdsfly
Copy link
Author

This is a big issue in our case. We use Hazelcast (30 nodes) to store web sessions.After upgrading to 3.12.2 from 3.8 sessions were not evicted anymore and started to pile up in production. We had to run external session cleanup job till we figured out what is causing it. We call removeAll when user requests to logout all sessions. It is frequent enough that sessions never expire with this bug.

@vbekiaris vbekiaris added this to the 4.0 milestone Sep 19, 2019
@vbekiaris vbekiaris self-assigned this Oct 23, 2019
This was referenced Oct 23, 2019
Merged
Merged
@vbekiaris
Copy link
Collaborator

@iseebirdsfly thanks for the excellent bug report & reproducer. PRs fixing this issue have been created; I will update this issue once they are reviewed.

@vbekiaris
Copy link
Collaborator

@iseebirdsfly the issue is now fixed in both master (4.0-SNAPSHOT) and maintenance-3.x (3.12.5-SNAPSHOT) branches.

@vbekiaris vbekiaris modified the milestones: 4.0, 3.12.5 Oct 29, 2019
@mmedenjak mmedenjak added the Source: Community PR or issue was opened by a community user label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vbekiaris vbekiaris

Labels
Module: IMap Source: Community PR or issue was opened by a community user Team: Core Type: Defect
Projects
None yet
Milestone
3.12.5
Development

Successfully merging a pull request may close this issue.

EntryProcessor with Predicate should not touch non-matching entries vbekiaris/hazelcast
3 participants
@vbekiaris @iseebirdsfly @mmedenjak