close the owner connection if heartbeat timeout when client is smart #2916
Conversation
close the owner connection if heartbeat timeout when client is smart
|
Hi I am not sure I understand the changes here. According the the commit comment the ownerConnection is now closed if the client is using smart routing, but this was always the case. The main difference I can see is that the passed in connection is no longer closed if using smart routing. |
|
No, it was not always the case. We were not closing any connection before this commit in smart routing. And we were relying on cluster listener to get updated member list. Only after that we were closing the connections. Problem with this approach happens when cluster listener thread is using unresponsive connection . It will never get a chance to get updated member list, hence it will wait forever. With this commit, we are closing only owner connection so that it can reestablishes it to a healthy connection. |
|
Thank you for the explanation. I will test my scenario tomorrow and see if it has been resolved. |
…07 (#2916) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> GitOrigin-RevId: 80e0492202b13bed9adf1d23b90014740642bf95
fixes #2850