Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High complexity ActionConstants getPermission #3160

Closed
pveentjer opened this issue Aug 6, 2014 · 0 comments · Fixed by #3185
Closed

High complexity ActionConstants getPermission #3160

pveentjer opened this issue Aug 6, 2014 · 0 comments · Fixed by #3185
Labels
Source: Internal PR or issue was opened by an employee
Milestone
3.3

Comments

@pveentjer
Copy link
Contributor

In the getPermission and if else chain is used. So the complexity of getPermission is O(N), with N being the number of permissions. Would it not be an idea to put them in a map and add a function as value that created a permission? Then the complexity would be O(1).
@pveentjer pveentjer mentioned this issue Aug 7, 2014
Merged
@pveentjer pveentjer added this to the 3.3 milestone Aug 7, 2014
@pveentjer pveentjer removed the PENDING label Aug 7, 2014
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Source: Internal PR or issue was opened by an employee
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Fixes 3160: ActionConstants complexity pveentjer/hazelcast
2 participants
@pveentjer @mmedenjak