`onExecutionFailure` should be called before returning from `run` if backup is not valid #6420

Closed
serkan-ozal opened this Issue Oct 10, 2015 · 0 comments

Projects

None yet

1 participant

@serkan-ozal
Contributor

After this PR #6301, Backup operation can be read directly as object without reading it first as Data temporary.

However after the backup operation is read (deserialized) as object, if it is decided (at Backup::beforeRun so valid field is false) that current node is not backup of this replica anymore, Backup::run returns silently. But before it returns, it should call onExecutionFailure of the backup operation otherwise it causes native memory leaks due to undisposed native memory.

@serkan-ozal serkan-ozal self-assigned this Oct 10, 2015
@serkan-ozal serkan-ozal added this to the 3.6 milestone Oct 10, 2015
@gurbuzali gurbuzali closed this in #6431 Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment