Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`onExecutionFailure` should be called before returning from `run` if backup is not valid #6420

Closed
serkan-ozal opened this issue Oct 10, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@serkan-ozal
Copy link
Contributor

commented Oct 10, 2015

After this PR #6301, Backup operation can be read directly as object without reading it first as Data temporary.

However after the backup operation is read (deserialized) as object, if it is decided (at Backup::beforeRun so valid field is false) that current node is not backup of this replica anymore, Backup::run returns silently. But before it returns, it should call onExecutionFailure of the backup operation otherwise it causes native memory leaks due to undisposed native memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.