Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMap: Change default minEvictionCheckMillis to 0 #7268

Closed
jerrinot opened this issue Jan 7, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@jerrinot
Copy link
Contributor

commented Jan 7, 2016

minEvictionCheckMillis controls maximum frequency of evictions. It's 100ms by default. It means at most 1 eviction will be executed in a 100ms interval. No other put() within this interval will trigger an eviction -> if put rate is greater than 1 per 100ms than number of entries is growing regardless of max. size policy -> Max size config is effectively ignored!

This eventually triggers a forced eviction which will prevent OOM -> forced evictions are only hiding this issue.

Another possible solution is keep the default interval as it is and apply batching: When we skip X eviction cycles due the minEvictionCheckMillis parameter then during the next cycle we should evict X + 1 entries instead of just 1.

@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2016

update: we are not changing default. instead we are ignoring this parameter if and only if NATIVE InMemoryFormat is selected.

@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2016

@jerrinot jerrinot closed this Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.