Fix/3.0/issue 724 #728
Merged
Fix/3.0/issue 724 #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devOpsHazelcast
pushed a commit
that referenced
this pull request
Feb 15, 2024
…728) As identified in HZ-4343, it is currently not possible to WAN replicate from 1 cluster to multiple other clusters when all clusters share the same cluster name. This is because the `AbstractWanPublisher#publishReplicationEventInternal` method checks and maintains each batch event's list of cluster names, returning early if the list already contains the target cluster's name. This check is done to prevent infinite loops when forwarding (republishing) is enabled - however, when republishing is not enabled, it is not possible to create an infinite loop scenario as the target does not try to produce additional WAN events. This commit simply introduces a new method to `WanPublisher` which is specific for republished replication, and is called from the `WanPutOperation` which handles forwarded WAN events. This allows us to skip these cluster name checks if the event is not being republished. This commit also adds to the javadoc of `WanReplicationRef` to show the default value of republishing WAN events, and a simple regression test to validate functionality. Fixes https://hazelcast.atlassian.net/browse/HZ-4343 GitOrigin-RevId: 4761a525314f9dde0324de647eea2f5e1359a9cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.