Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country language data #37

Open
hbb20 opened this issue Jul 31, 2021 · 10 comments
Open

Country language data #37

hbb20 opened this issue Jul 31, 2021 · 10 comments
Labels
feature-request A new feature that can be useful to devs

Comments

@hbb20
Copy link
Owner

hbb20 commented Jul 31, 2021

There are use cases of language data for country.

@hbb20 hbb20 added the feature-request A new feature that can be useful to devs label Jul 31, 2021
@HerbertWest6
Copy link

We can provide translations for DE, EN, RU, HU, LT
It's the languages which we need.

@HerbertWest6
Copy link

Do I understand correctly that https://github.com/hbb20/CountryCodePickerProject is like a parent project?
It already offers DE, EN and RU translations as far as I am able to see.
As far as I understand https://github.com/hbb20/CountryCodePickerProject/wiki/Add-New-Language-Support we can add HU and LT and you merge it and roll out?

@HerbertWest6
Copy link

HerbertWest6 commented Jul 6, 2023

I just tried com.hbb20:ccp:2.7.2 on a german phone and it was not german. I don't get it. Please get in contact with me

EDIT: Okay got it. The solution to show all countries in local language is app:ccp_autoDetectLanguage="true"

@HerbertWest6
Copy link

Okay different question: assuming our translation team provides the translation for HU and LT and I write the merge request for you -- will the updated version be rolled out quickly? Will you create a new version and roll it out? I don't know your roll out policy for your project

@hbb20
Copy link
Owner Author

hbb20 commented Jul 6, 2023

So Android Country Picker (ACP) is new and improved library of Country Code Picker library (CCP). Although they don't share any code. Not even translations. There are key differences:

  1. CCP was bloated with too many functionalities that developers don't really need and increases apk size. Android Country Picker (ACP) will to stick to functionalities that are related to country and country selection. So country code selection will be a subset of it's features but also features like phone number verification and formatting will be dropped.
  2. CCP provides minimum config control to developer while ACP gives full control. In fact you can create your own UI if you wish and just use the data that comes from ACP.

Given these differences, can you tell me which library you are using? I can help you with expedited release.

@HerbertWest6
Copy link

We can provide country translations for DE, EN, RU, HU and LT and you put them into the library?

@hbb20
Copy link
Owner Author

hbb20 commented Jul 7, 2023

I am still not sure which library you need to use. Are you looking forward to use CCP (the other library) or this Android Country Picker library?

For, CCP, I can accept PR and expedite release. You can follow the wiki document to add support for language.
https://github.com/hbb20/CountryCodePickerProject/wiki/Add-New-Language-Support

For, ACP, I am in process of updating the flow that makes it easier for developers to add language support. The implementation is almost done, I need to add the documentation. I can spend some time on this in day or two that can unblock you from creating PRs.

Let me know which one you need.

@HerbertWest6
Copy link

As far as I can see it both options work for us.
CCP already offers more languages so I'd extend that I guess.

@hbb20
Copy link
Owner Author

hbb20 commented Jul 10, 2023

Makes sense. Looking forward to see your PR so I can make release.

@HerbertWest6
Copy link

😄 hbb20/CountryCodePickerProject#583
Hungarian was already available so I only added lithuanian.

Our customer requires DE, EN, RU, HU and LT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A new feature that can be useful to devs
Projects
None yet
Development

No branches or pull requests

2 participants