Improve faker example #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
hbelmiro
requested changes
Sep 11, 2022
There was a problem hiding this comment.
Thanks for this PR, @snuyanzin. I really appreciate it.
I just created a new branch named "main" to receive code improvements. The original code is not supposed to receive any meaningful updates (you can see the reason for that in the preamble here).
Can you please change this PR to target the "main" branch instead of the "master" branch?
Also, do you mind updating https://github.com/hbelmiro/100DaysOfJava/tree/main/days/day095/src/main/java/com/thegreatapi/ahundreddaysofjava/day095?
Javafaker is no longer supported there is datafaker https://github.com/datafaker-net/datafaker which is a fork of javafaker and has many more featured which are not merged to javafaker
|
I created a new PR to main #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javafaker is no longer supported
there is datafaker https://github.com/datafaker-net/datafaker which is a fork of javafaker and has many more featured which are not merged to javafaker