Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split packet so npm users don't need to install pupeteer on pure browser installation #115

Closed
napalu opened this issue Mar 10, 2019 · 8 comments

Comments

@napalu
Copy link

napalu commented Mar 10, 2019

Would be nice for those of us using npm as a package manager for our browser-based development to have an npm package which does not pull puppeteer on install.

@hbi99
Copy link
Owner

hbi99 commented Mar 10, 2019

Thanks for the feedback...looking in to this

@hbi99
Copy link
Owner

hbi99 commented Mar 10, 2019

Hi again @napalu,
So I've been looking around regarding this but haven't found a good guideline / example. Do you have any suggestion or point to a direction to resolve this issue?

Thanks in advance

@napalu
Copy link
Author

napalu commented Mar 11, 2019

Hi @hbi99 I was thinking it could be split in 2 packages.

  1. defiant.js-all (nodejs dependencies + defiant.js)
  2. defiant.js (or defiant.js-core) for browsers

It would mean maintaining two separate package builds. I'll try to see if there's an easier way but right now nothing comes to mind.

@hbi99
Copy link
Owner

hbi99 commented Mar 13, 2019

Hi @napalu,
Splitting into 2 packages does not sound appealing - even though I am considering it as an option.
I'll research more to see how others might have solved it.

Meanwhile, can you give me a gist of your npm commands, when installing packages for browser environment?

Thanks in advance

@hbi99
Copy link
Owner

hbi99 commented Mar 24, 2019

Since, I am not getting feedback on this issue, I am closing it. Re-open it if you want to pursue this issue.

@hbi99 hbi99 closed this as completed Mar 24, 2019
@tomyun
Copy link

tomyun commented Jul 19, 2019

I'm stuck with the same issue as OP. Do we have any solution yet?

@simonguillen
Copy link

Any solution on this? I wanted to implement this on React but I seem to encounter issues with Puppeteer being unable to run on a React app.

https://stackoverflow.com/questions/60700861/cant-run-puppeteer-in-react-app-module-not-found-cant-resolve-ws-when-comp

Hope this issue gets reopened.

@hbi99
Copy link
Owner

hbi99 commented May 22, 2023

I removed puppetter support in v2.2.8
Does it help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants