Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All class option on config read #7

Open
cazaman11 opened this issue May 18, 2024 · 2 comments
Open

All class option on config read #7

cazaman11 opened this issue May 18, 2024 · 2 comments
Labels
discussion Discuss new features or requests

Comments

@cazaman11
Copy link

More of a feature than a bug imo. When first opening the app, you're unable to modify the weapon and crosshair dropdowns and required to select a class. however if you click the read config button it will make those dropdowns selectable allowing you to apply to all classes if you dont select a class.

I think it'd be best to keep this feature but have it more accessable with either a clearing the class option or an all class option.

@hbivnm hbivnm added the discussion Discuss new features or requests label May 20, 2024
@hbivnm
Copy link
Owner

hbivnm commented May 20, 2024

I'm not sure what you mean with having it more accessible, you are able to apply a single crosshair to all classes by:

  1. Going through the normal UI flow of choosing a class -> weapon -> crosshair -> check relevant checkboxes
    image

  2. Different, but slightly unintended, way by reading config -> select a crosshair -> check relevant checkboxes
    VenomCrosshairs_VsZ1W7cWEb

The dropdowns and checkboxes are explicitly grayed out to have some form of flow to not confuse the user with a boatload of dropdowns, checkboxes and buttons (hence settings and console are hidden by default).

I'd be more than happy to consider other alternatives if you'd like to explain step-by-step and/or show with examples of having more options to apply things to all classes! :)

@cazaman11
Copy link
Author

It never crossed my mind that even if you have a class picked in the dropdown you can have the "add only to class check" unchecked and then the other checks apply across classes to have it be all class.

I suppose its alright then, I couldn't figure out how to do all class and guess I stumbed upon the wrongest way to do it. I will say if you check the "Add ONLY to class" like this it will error but is known since you put that error out in the switch case.

In terms of it being a bit more ux friendly I could give a try to see if its makes sense to add an all class dropdown and omit the add only class check.

Otherwise good work with this tool, I thought I found something a bit odd with the read config and enabled fields but guess not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discuss new features or requests
Projects
None yet
Development

No branches or pull requests

2 participants