fix x/y swapping and add demo #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbldh
requested changes
Dec 9, 2021
|
@hbldh I think I have addressed all points you mentioned. |
hbldh
approved these changes
Dec 9, 2021
|
PR is merged and a new release has been deployed to PyPI. Thank you and well done! |
|
Thanks to you for putting up this code in the first place and also for the quick reaction to this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that in some places apparently the x/y dimension was mixed up and I attempted to fix this.
As a test and demo, I added a few geometric figures to showcase this method.
Best regards,
Jonathan