Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: normalize_efd function that also outputs angle and scale #5

Closed
geloescht opened this issue Aug 13, 2019 · 1 comment · Fixed by #13
Closed

Feature request: normalize_efd function that also outputs angle and scale #5

geloescht opened this issue Aug 13, 2019 · 1 comment · Fixed by #13

Comments

@geloescht
Copy link
Contributor

Thank you very much for this beautiful piece of software. For my purposes it would be great to also get the normalization angle and scale in order to store it alongside the descriptor for future lookups. Would it be possible to have a analogous function to normalize_efd that outputs those values and the normalized descriptor as a tuple?

@hbldh
Copy link
Owner

hbldh commented Aug 14, 2019

It would definitely be possible. The simplest way would be adding a keyword, like return_normalization_parameters=False and check if it is set to True before returning and in that case return coeffs, (coeffs[0, 0], psi_1, theta_1) instead.

You are very welcome to make a PR implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants