"Add Host Project" should be disabled, if not allowed. #711

Closed
ghost opened this Issue Apr 19, 2012 · 4 comments

Comments

Projects
None yet
1 participant
@ghost

ghost commented Apr 19, 2012

If I try to add a project while another is adding, the same progress window is reused (possibly aborting the adding process?).
Not that this should necessarily be supported, but the "Add Host Project" should be disabled, if not allowed.

Additionally, if I try to add the same project, SparkleShare crashes.

Os: Mac OS-X 10.7.3

Owner

hbons commented Apr 19, 2012

I've left the item enabled, so you can easily get back to the dialog that you might have forgotten about.
Can you post the console.app output for the crash?

@ghost

ghost commented Apr 19, 2012

It makes sense.
When you click there, though, it goes back to the "Where's your project hosted?" dialog.

Log of the crash, when pressing the Add button again, leaving data unchanged.

19/04/12 12:59:08,946 [0x0-0x9f09f].org.sparkleshare.sparkleshare: 12:59:08 [Fetcher][/Users/djjeck/SparkleShare/.tmp/Shared] Fetching folder: ssh://djjeck@5.37.195.1/Volumes/1Tb/SparkleShare/Shared
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: Unhandled Exception: System.UnauthorizedAccessException: Access to the path "/Users/djjeck/SparkleShare/.tmp/Shared/.git/objects/pack/tmp_pack_2NlTWb" is denied.
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.File.Delete (string) <0x0019f>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x000c7>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x0007b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x0007b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x0007b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.Delete (string,bool) <0x0002b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleLib.SparkleFetcherBase.Start () <0x00097>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleControllerBase.FetchFolder (string,string,string) <0x0076f>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleSetupController.AddPageCompleted (string,string) <0x001b3>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleSetup/c__AnonStoreyC.<>m__45 (object,System.EventArgs) <0x0005f>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at MonoMac.AppKit.ActionDispatcher.OnActivated (MonoMac.Foundation.NSObject) <0x00027>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at (wrapper dynamic-method) object.MonoMac.AppKit.ActionDispatcher.Void OnActivated(MonoMac.Foundation.NSObject) <0x00033>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at (wrapper native-to-managed) object.MonoMac.AppKit.ActionDispatcher.Void OnActivated(MonoMac.Foundation.NSObject) <0x000fb>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at (wrapper managed-to-native) MonoMac.AppKit.NSApplication.NSApplicationMain (int,string[]) <0x00003>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at MonoMac.AppKit.NSApplication.Main (string[]) <0x00017>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleUI.Run () <0x00023>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.Program.Main (string[]) <0x002a3>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: [ERROR] FATAL UNHANDLED EXCEPTION: System.UnauthorizedAccessException: Access to the path "/Users/djjeck/SparkleShare/.tmp/Shared/.git/objects/pack/tmp_pack_2NlTWb" is denied.
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.File.Delete (string) <0x0019f>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x000c7>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x0007b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x0007b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.RecursiveDelete (string) <0x0007b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at System.IO.Directory.Delete (string,bool) <0x0002b>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleLib.SparkleFetcherBase.Start () <0x00097>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleControllerBase.FetchFolder (string,string,string) <0x0076f>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleSetupController.AddPageCompleted (string,string) <0x001b3>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleSetup/c__AnonStoreyC.<>m__45 (object,System.EventArgs) <0x0005f>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at MonoMac.AppKit.ActionDispatcher.OnActivated (MonoMac.Foundation.NSObject) <0x00027>
19/04/12 12:59:09,589 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at (wrapper dynamic-method) object.MonoMac.AppKit.ActionDispatcher.Void OnActivated(MonoMac.Foundation.NSObject) <0x00033>
19/04/12 12:59:09,590 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at (wrapper native-to-managed) object.MonoMac.AppKit.ActionDispatcher.Void OnActivated(MonoMac.Foundation.NSObject) <0x000fb>
19/04/12 12:59:09,590 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at (wrapper managed-to-native) MonoMac.AppKit.NSApplication.NSApplicationMain (int,string[]) <0x00003>
19/04/12 12:59:09,590 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at MonoMac.AppKit.NSApplication.Main (string[]) <0x00017>
19/04/12 12:59:09,590 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.SparkleUI.Run () <0x00023>
19/04/12 12:59:09,590 [0x0-0x9f09f].org.sparkleshare.sparkleshare: at SparkleShare.Program.Main (string[]) <0x002a3>

Is that bad, doctor? =)

Owner

hbons commented Apr 19, 2012

Oh, that definitely shouldn't happen, it should stay on the progressbar page.

@hbons hbons closed this in 8cfc824 Apr 19, 2012

Owner

hbons commented Apr 19, 2012

That fixes it. I've opened a separate issue for the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment