Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live code functionality puts "copy to clipboard" in code boxes #256

Closed
m-r-schenk opened this issue Feb 16, 2022 · 6 comments
Closed

Live code functionality puts "copy to clipboard" in code boxes #256

m-r-schenk opened this issue Feb 16, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@m-r-schenk
Copy link
Collaborator

When Thebe is launched to start live coding, the "Copy to clipboard" button turns into text, making the code unable to run.

This happens only on the website. Doing this on a local build does not cause this error.

image

@joergbrech
Copy link
Member

@PhiSpel PhiSpel assigned PhiSpel and unassigned PhiSpel Feb 18, 2022
@joergbrech
Copy link
Member

joergbrech commented Feb 23, 2022

Should be fixed in latent jupyter book version

@PhiSpel PhiSpel added the bug Something isn't working label Feb 23, 2022
@PhiSpel PhiSpel mentioned this issue Apr 5, 2022
1 task
@PhiSpel
Copy link
Collaborator

PhiSpel commented Apr 5, 2022

We still build with an older version, is this intended, @joergbrech ? See #310 , if we can always get the latest version?

https://github.com/joergbrech/Modellbildung-und-Simulation/blob/d3543e9688f0f829daf178322e9c9aa32d3da4c7/requirements.txt#L1

Edit: This does not solve the copy to clipboard issue...

@PhiSpel
Copy link
Collaborator

PhiSpel commented Nov 26, 2022

In #460, copy to clipboard is no longer put into the code box

@PhiSpel PhiSpel assigned PhiSpel and unassigned PhiSpel Jan 6, 2023
@PhiSpel
Copy link
Collaborator

PhiSpel commented Jan 10, 2023

Finally, I don't get the copy to clipboard issue any more!

@Florian314, can you just quickly confirm this by opening https://hbrs-cse.github.io/Modellbildung-und-Simulation/intro.html and activating live code on the top right - does copy to clipboard show up in the code box?

@PhiSpel PhiSpel self-assigned this Jan 10, 2023
@PhiSpel
Copy link
Collaborator

PhiSpel commented Jan 12, 2023

This issue can be closed as it was solved by updating our jupyter-book version.

As @joergbrech , Chris, and Steve are doing amazing work over at executablebooks/sphinx-thebe#60, I expect we will not need to revert the jupyter-book version. And, anyway, we would not be able to close this issue on the older version.

@PhiSpel PhiSpel closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants