Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust attribution for wikimedia images #334

Closed
acka47 opened this issue Mar 22, 2017 · 3 comments
Closed

Adjust attribution for wikimedia images #334

acka47 opened this issue Mar 22, 2017 · 3 comments

Comments

@acka47
Copy link
Contributor

acka47 commented Mar 22, 2017

Re. #321 (comment). Instead of using imageinfo.Artist.value we should use imageinfo.Attribution.value for the creator attribution.

@acka47
Copy link
Contributor Author

acka47 commented Mar 22, 2017

The reason: users can basically put anything into the "creator" field in Wikimedia Commons. Showing all the content of the field in lobid-organisations isn't necessary. Here is a quite extreme case that dosn't look good at all:

kasten

@acka47
Copy link
Contributor Author

acka47 commented Mar 22, 2017

I just noticed that this won't work for the example shown as you don't get back the Attribution information via the API, see https://commons.wikimedia.org/w/api.php?action=query&format=json&prop=imageinfo&list=&titles=file%3AMuenster_Dioezesanbibliothek_4634.jpg+&iiprop=extmetadata. https://lizenzhinweisgenerator.de/ gives back a very long attribution text for this image.

I am not sure whether it would make sense to prefer the Attribution object if available over the Artist object. Leaving this open for now.

@acka47
Copy link
Contributor Author

acka47 commented Jul 12, 2017

Closing.

@acka47 acka47 closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants