Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Implement basic HTML form for Person type #450

Closed
literarymachine opened this issue Nov 12, 2015 · 9 comments
Closed

Implement basic HTML form for Person type #450

literarymachine opened this issue Nov 12, 2015 · 9 comments
Assignees

Comments

@literarymachine
Copy link
Contributor

Task for #22 & #23

@acka47
Copy link
Contributor

acka47 commented Nov 13, 2015

Both peoperties "description" (https://github.com/hbz/oerworldmap/blob/master/public/json/schema.json#L525-L527) and sameAs (https://github.com/hbz/oerworldmap/blob/master/public/json/schema.json#L569-L575) are part of the "Person" schema. They are not shown in the HTML form, though.

@acka47 acka47 assigned literarymachine and unassigned acka47 Nov 13, 2015
@acka47 acka47 added 2 - Tasklog and removed review labels Nov 13, 2015
@literarymachine
Copy link
Contributor Author

Fixed on beta & production.

@acka47
Copy link
Contributor

acka47 commented Nov 13, 2015

Regarding #452, we should remove affiliation from the web form and add memberOf instead.

@acka47
Copy link
Contributor

acka47 commented Nov 17, 2015

Several times I had problems with an email I copy&pasted from a google spreadsheet. Everything would look ok but when I click on save there would be the following error message:

20151117_mail-bug

When I type in the same email, everything is fine and the edits can be saved.

@literarymachine
Copy link
Contributor Author

There seems to be an illegal character in the copied content then (probably a newline character, which is not valid in email addresses). We are using your browsers HTML5 support for validation here, more specifically the email input type. Not much we can do about that.

@acka47
Copy link
Contributor

acka47 commented Nov 17, 2015

So we don't have influence on the wording of the error message?

@literarymachine
Copy link
Contributor Author

We could - but a newline is an invisible character nevertheless. On top of that, setting custom validity will only work for users with Javascript enabled, so this cannot be part of the current basic versions of the forms.

@acka47
Copy link
Contributor

acka47 commented Nov 17, 2015

What I meant was showing a rather generic error message as this seems to be wrong or at least confusing. You can easily read it like: We don't want a period . before an @. Thus, a general message like "Oups, something went wrong. Please again type in your email address." would be better.

@literarymachine
Copy link
Contributor Author

What I meant was showing a rather generic error message

Whatever the message is, we would have to overwrite the browser settings, and this needs Javascript. So, like I said, this is not possible in the non-Javascript base forms.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants