Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate IHCaptchaHtmlProvider implementation at build time #62

Closed
CAMOBAP opened this issue Jul 22, 2022 · 2 comments
Closed

Generate IHCaptchaHtmlProvider implementation at build time #62

CAMOBAP opened this issue Jul 22, 2022 · 2 comments
Assignees
@CAMOBAP
Labels
enhancement New feature or request

Comments

@CAMOBAP
Copy link
Collaborator

CAMOBAP commented Jul 22, 2022

Intro

A nice proposal was made by @DSergiu #61 (comment) . Because maintaining embedded HTML it's really error-prone and not convenient

Proposal

Put back hcaptcha-form.html (but keep it outside of assets) and generate IHCaptchaHtmlProvider at build time

TODO Check existing code-gen plugins for gradle to keep Androd Studio happy (and not report missing classes)
@CAMOBAP CAMOBAP self-assigned this Jul 22, 2022
@CAMOBAP CAMOBAP mentioned this issue Jul 22, 2022
Merged
@e271828- e271828- added the enhancement New feature or request label Jul 23, 2022
@e271828- e271828- changed the title Generate IHCaptchaHtmlProvider implementation for at build time Generate IHCaptchaHtmlProvider implementation at build time Jul 25, 2022
@cryptoroland

This comment was marked as spam.

Sign in to view
CAMOBAP added a commit that referenced this issue Nov 9, 2022
@CAMOBAP
#62 generate HCaptchaHtml.java from hcaptcha.html
ef3e248
@CAMOBAP CAMOBAP mentioned this issue Nov 9, 2022
Closed
@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Jan 16, 2023

PR is ready for review #80

DSergiu added a commit that referenced this issue Jan 23, 2023
@CAMOBAP @DSergiu
refactor: generate html from java (#80)
9f32ce4 
* #62 generate HCaptchaHtml.java from hcaptcha.html

* Don't keep generated HCaptchaHtml.java in git

* Fix sonar issues for hcaptcha.html

* fix: not centered

* Add missing DOCTYPE HTML to fix codesmell

* Do clean before building aar from default branch

* feat(sdk): move android.permission.INTERNET to sdk's AndroidManifest

* chore(test): add e2e tests with debug token

* test(sdk): increase e2e test timeouts

Co-authored-by: Sergiu Danalachi <danalachi.sergiu@gmail.com>
@CAMOBAP CAMOBAP closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CAMOBAP CAMOBAP

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CAMOBAP @e271828- @cryptoroland