Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port-forward to pods not available #260

Closed
allemp opened this issue Jun 14, 2024 · 4 comments
Closed

Port-forward to pods not available #260

allemp opened this issue Jun 14, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@allemp
Copy link

allemp commented Jun 14, 2024

Describe the bug

Issue #23 mentions that it should be possible to port-forward to pods, but only service and proxy are available in the workload type list

Expected behavior

I expected to be able to select pods as a workload type to to select the pod I want to forward.

Desktop (please complete the following information):

  • MacOS Sonoma 14.5

Additional context

If it was not intentional to allow port-forwarding to pods or I missed something then disregard.

Thanks!

@hcavarsan
Copy link
Owner

hey @allemp ,

i've thought about this and didn't implement port-forward directly to pods because if it's a specific pod name, the config will only be valid while the pod is running. once the pod is terminated, the config in kftray would stop working.

but i get that today you need a service created for port-forward to work, and this doesn't cover some cases.

what i'm thinking is to have a workload_type pod and instead of selecting the pod name, select a pod label for port-forward.

do you think this would work?

@allemp
Copy link
Author

allemp commented Jun 14, 2024

Hello! I think that would work just fine!

@hcavarsan
Copy link
Owner

hey @allemp , ive implemented the new workload_type called pod, making it possible to select and forward via pod labels.

new version: https://github.com/hcavarsan/kftray/releases/tag/v0.12.0

could you please test it to see if everything is working fine?

@allemp
Copy link
Author

allemp commented Jun 20, 2024

I tested it and it works great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants