Bump pyyaml and specify explicit FullLoader for yaml #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version for pyyaml has been restricted because it has started to require an explicit loader for loading yaml files. By appliying this commit, we can now remove the restriction, since we explicitly specify the loader.
|
Hi @palicand, thank you for the contribution. Would you mind also bumping the setup.py version to 0.3.0 as part of this PR? |
|
Hi, not at all. I’ll bump it later today. |
Version bumped, please review :-) |
hchasestevens
approved these changes
Dec 9, 2019
|
@palicand I've released 0.3.0 -- thanks again for the PR! |
|
@hchasestevens thanks for the merge and quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version for pyyaml has been restricted because it has started to require
an explicit loader for loading yaml files (see #20).
By applying this commit, we can now remove the restriction,
since we explicitly specify the loader.
We had to bump the lower bound for pyyaml to
>=4.0because3.xversions did not have aFullLoader, which is required for this to work properly.