Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete rewrite (v4.0.0) #23

Closed
12 tasks done
hchiam opened this issue Jan 31, 2021 · 9 comments · Fixed by #24
Closed
12 tasks done

complete rewrite (v4.0.0) #23

hchiam opened this issue Jan 31, 2021 · 9 comments · Fixed by #24
Assignees

Comments

@hchiam
Copy link
Owner

hchiam commented Jan 31, 2021

Modernize. Also clean up project structure (#20), package.json commands (#21), and hopefully the a11y issues found by aXe (#10).

  • create new branch main
  • keep copy of master branch contents locally for reference
  • clear everything out (locally only) in main branch
  • npx create-next-app . https://github.com/hchiam/learning-nextjs
  • take useful things like scripts from master to main
    • don't forget the extra pages
    • don't forget the color style on the draggable
    • don't forget the service worker (or decide whether to drop it)
      • get service worker (sw.js) to automatically figure out what files to cache
  • lhci
  • travis CI
  • don't forget to set Enforce HTTPS

Now follow the steps in the PR #24

@hchiam hchiam self-assigned this Jan 31, 2021
@hchiam hchiam pinned this issue Jan 31, 2021
@hchiam
Copy link
Owner Author

hchiam commented Feb 7, 2021

@hchiam
Copy link
Owner Author

hchiam commented Feb 10, 2021

consider CSA for even better DX: https://github.com/hchiam/learning-create-snowpack-app

@hchiam
Copy link
Owner Author

hchiam commented Feb 12, 2021

@hchiam
Copy link
Owner Author

hchiam commented Feb 12, 2021

vercel/next.js#21679
shadowwalker/next-pwa#151
yarn add webpack@webpack-4

@hchiam
Copy link
Owner Author

hchiam commented Feb 12, 2021

@hchiam
Copy link
Owner Author

hchiam commented Feb 12, 2021

example lhci assertions settings, like minScore or maxNumericValue: https://github.com/leanazulyoro/next-lhci-example/blob/develop/lighthouserc.json

@hchiam hchiam mentioned this issue Feb 12, 2021
13 tasks
@hchiam hchiam closed this as completed Feb 12, 2021
@hchiam hchiam unpinned this issue Feb 12, 2021
@hchiam
Copy link
Owner Author

hchiam commented Feb 13, 2021

main branch deploys correctly to https://hchiam.surge.sh/ but not to https://hchiam.com/
gh-pages branch doesn't deploy correctly to https://hchiam.com/ either

@hchiam hchiam reopened this Feb 13, 2021
@hchiam hchiam pinned this issue Feb 13, 2021
@hchiam
Copy link
Owner Author

hchiam commented Feb 14, 2021

.nojekyll in root of gh-pages branch seems most likely to get this working, since https://hchiam.surge.sh already works with just the /out folder, while the github.io version doesn't (and both were deployed by the same script)

@hchiam
Copy link
Owner Author

hchiam commented Feb 14, 2021

finally got it working! 2bd73e4 on main (and also 06a7a11 on gh-pages autogenerated by yarn deploy or yarn deploy:gh-pages) - see files at that point in history to see the setup that worked

@hchiam hchiam closed this as completed Feb 14, 2021
@hchiam hchiam unpinned this issue Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant