Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIT should KILL slave process after timeout #27

Closed
hcoles opened this issue Jan 7, 2014 · 5 comments
Closed

PIT should KILL slave process after timeout #27

hcoles opened this issue Jan 7, 2014 · 5 comments

Comments

@hcoles
Copy link
Owner

hcoles commented Jan 7, 2014

From stefan.p...@googlemail.com on February 09, 2012 09:31:35

PIT should kill the slave process executing the test(s) against the mutation(s) after some time. If the test is badly designed or the mutation fails to stop a non-deamon thread, PIT hangs forever.

I've got a project that creates a ThreadPoolExecutor and fails to shutdown() that executor after the test finishes. The threads of the executor stay alive and prevent the slaves JVM from terminating. This causes PIT to hang forever waiting for the slave process to die.

It would be better if PIT does not wait forever put applies a timeout and kills the process after the timeout.

I've attached a patch with a system test demonstrating the scenario/issue.

Attachment: threadpool-fails-to-shutdown.patch

Original issue: http://code.google.com/p/pitestrunner/issues/detail?id=27

@hcoles
Copy link
Owner Author

hcoles commented Jan 7, 2014

From stefan.p...@googlemail.com on February 09, 2012 03:43:33

Please note that this issue might be related to issue 12 (or might be a duplicate of issue 12 ).

I've run my test case with the latest pitest version from mercurial repository but test case still fails.

@hcoles
Copy link
Owner Author

hcoles commented Jan 7, 2014

From henry.co...@googlemail.com on February 09, 2012 06:49:54

Hi Stefan,

Yes I suspect this is the same issue. Thanks for the report and the test case.

@hcoles
Copy link
Owner Author

hcoles commented Jan 7, 2014

From henry.co...@googlemail.com on February 09, 2012 11:16:23

Fix pushed to default branch

@hcoles
Copy link
Owner Author

hcoles commented Jan 7, 2014

From henry.co...@googlemail.com on March 16, 2012 05:16:52

Status: PendingRelease

@hcoles
Copy link
Owner Author

hcoles commented Jan 7, 2014

From henry.co...@googlemail.com on April 03, 2012 13:39:28

fixed in 0.26

Status: Fixed

@hcoles hcoles closed this as completed Jan 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant