Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new := logical constraint syntax used by JuMP #83

Closed
pulsipher opened this issue Oct 16, 2023 · 1 comment · Fixed by #91
Closed

Support the new := logical constraint syntax used by JuMP #83

pulsipher opened this issue Oct 16, 2023 · 1 comment · Fixed by #91

Comments

@pulsipher
Copy link
Collaborator

JuMP just merged jump-dev/JuMP.jl#3530. We should update DisjunctiveProgramming to support this syntax. It means we'll need to support:

JuMP.add_constraint(model::JuMP.Model, c::JuMP.ScalarConstraint{<:_LogicalExpr, MOI.EqualTo{Bool}}, name::String = "")

Here, we are now guaranteed for EqualTo to always be of type Bool since the automatic conversion is disabled and it will never get affine expressions since it will no longer substract the RHS.

One decision to make, would be whether we just want to use MOI.EqualTo{Bool} to be consistent with other packages or keep using IsTrue.

@pulsipher
Copy link
Collaborator Author

As an update, JuMP has now released this syntax with v1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant