Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The keybinding for translateSelection (cmd+shift+p) overwrites the Command Palette keybinding in Mac #5

Closed
openopentw opened this issue Apr 22, 2023 · 2 comments · Fixed by #6
Closed

The keybinding for translateSelection (cmd+shift+p) overwrites the Command Palette keybinding in Mac #5

openopentw opened this issue Apr 22, 2023 · 2 comments · Fixed by #6

Comments

@openopentw
Copy link

Hi,

Thanks for the extension. This is useful!

However, the keybinding for translateSelection (shift+cmd+p) overwrites the Command Palette keybinding in Mac. You can check it here:

vscode-opencclint/package.json

Line 59 in df41cfd

"mac": "shift+cmd+p"

The keybinding for Command Palette is the most commonly used / referenced keybinding. It should not be overwritten and it may cause confusions!

It would be better to change it to some other keybindings like "ctrl+cmd+p" or "opt+cmd+p" etc.

I thought you may not be using a Mac so you did't notice it ;)
@hddhyq
Copy link
Owner

hddhyq commented May 12, 2023

ok, i will fix it.

@hddhyq
Copy link
Owner

hddhyq commented May 12, 2023

you can use the right-click menu first

@hddhyq hddhyq mentioned this issue Jul 27, 2023
Merged
@hddhyq hddhyq closed this as completed Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(keybinding): use ctrl+cmd+p replace shift+cmd+p hddhyq/vscode-opencclint
2 participants
@openopentw @hddhyq