hdf5_home_win does not get set

[mheppner]

I'm not very familiar with building native node modules, so I'm not sure if this is even an issue with this project. I was able to build this without any issues on Linux, but it took a bit of effort on Windows. I think the hdf5_home_win flag isn't getting set.

I tried setting it with --hdf5_home_win="C:\Program Files\HDF_Group\HDF5\1.10.4", and also with npm config set hdf5_home_win "C:\Program Files\HDF_Group\HDF5\1.10.4". Neither worked. Downloading this package with npm pack hdf5, untar'ing it, then changing the variable value "hdf5_home_win%" in binding.gyp, still didn't work. I finally got it to build after replacing all of the <(hdf5_home_win) placeholders in binding.gyp with the full path.

Windows 10
node v10.11.0
npm 6.4.1
windows-build-tools 5.1.0
HDF5 1.10.4

[mheppner]

I reinstalled HDF5 to C:\hdf5 and the npm config set hdf5_home_win config and --hdf5_home_win flag both seem to let the package build. I'm guessing it's because of the space in "Program Files"? Could this be documented somehow?

[rimmartin]

I'll experiment with spaces; not sure what gyp on windows expects. Thanks