Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FillValue no longer working #44

Closed
rsignell-usgs opened this issue Dec 4, 2017 · 6 comments
Closed

FillValue no longer working #44

rsignell-usgs opened this issue Dec 4, 2017 · 6 comments

Comments

@rsignell-usgs
Copy link
Contributor

rsignell-usgs commented Dec 4, 2017

I upgraded to the latest h5pyd, and now the fillvalues in my dataset are not working:
https://gist.github.com/rsignell-usgs/c3555fd60c391699197d53dcd0cb007c

The fill values in the original netcdf4 file were 1.0e37 but after writing with h5load the new h5pyd thinks the fillvalue is 0.0.

This same notebook worked at the ESIP summer meeting.

@ghost
Copy link

ghost commented Dec 15, 2017

Would it be possible to get the original file?

My theory (without a shred of evidence) is that there is some confusion as to from where the fill value should come. dset.fillvalue gives the fill value from the HDF5 dataset's creation property list. And it's default value is 0.0. What is the fill value you are referring to? The one stored in the dataset's _FillValue attribute?

@jreadey
Copy link
Member

jreadey commented Dec 15, 2017

I have the source file - I'll investigate.

@jreadey
Copy link
Member

jreadey commented Dec 17, 2017

I tried reloading the Sandy_ocean_his_nc4.nc file. Looks like both the dataset.fillvalue and dataset _FillValue attribute are set to 1.0e37.

@rsignell-usgs - would you try loading the file again? I think the files on jetstream got corrupted at some point.

@rsignell-usgs
Copy link
Contributor Author

The fill values work as expected with this HSDS "file":
/home/rsignell/Sandy_ocean_his_nc4.nc
but get returned as 0.0 with this "file":
/home/rsignell/Sandy_ocean_his_nc4c.nc

I created fresh versions of these today using "hsload".

@rsignell-usgs
Copy link
Contributor Author

I wonder if it's a function of compression?

@jreadey
Copy link
Member

jreadey commented Dec 2, 2022

I think this should be fixed with the commit in issue #119.
Please re-open if you are still seeing this.

@jreadey jreadey closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants