Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Some configuration entries must be set as env variables ? #69

Closed
loichuder opened this issue Oct 28, 2020 · 4 comments
Closed

Comments

@loichuder
Copy link
Contributor

loichuder commented Oct 28, 2020

Seeing #50, I thought that I could set all parameters in config.yml.

I was however proven wrong when running runall.sh. Checks are made on ROOT_DIR and HSDS_ENDPOINT that therefore must be set as environment variables.

Is this the expected behaviour or am I missing something to use the root_dir and hsds_endpoint entries in the config.yml ?

@jreadey
Copy link
Member

jreadey commented Nov 2, 2020

Hey @loichuder - yes, that's expected. There are some environment variables like ROOT_DIR that are used by ./runall.sh to determine which docker_compose file to invoke. E.g. if ROOT_DIR is set, it assumes that you want to use the posix HSDS: https://github.com/HDFGroup/hsds/blob/master/admin/docker/docker-compose.posix.yml.

Others environment variables like AWS_ACCESS_KEY_ID are not set in config.yml because that would be a security risk to have in a text file.

And finally there are some variables that are by Docker in the compose file rather than accessed by the container. E.g. "DN_RAM" sets how much memory is allotted to each DN container.

Let me know if you still have questions about this.

@loichuder
Copy link
Contributor Author

I see.

I indeed want to use the POSIX HSDS. In this case, there is no point setting root_dir in config.yml as it will be overwritten by ROOT_DIR anyway, right ?

@jreadey
Copy link
Member

jreadey commented Nov 13, 2020

Right - the docker-compose.posix.yml needs ROOT_DIR to set the volume mount.

@jreadey
Copy link
Member

jreadey commented Nov 17, 2020

Closing - please re-open if you have questions.

@jreadey jreadey closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants