Allow CircleImageView to work with ColorDrawables

[ianhanniballake]

I use ColorDrawables as placeholders while profile pictures are being loaded from the network. However, ColorDrawables have an intrinsic height and width of -1, causing Bitmap.createBitmap to fail in CircleImageView.getBitmapFromDrawable.

[thevery]

+1!

[thevery]

can you please make generic fix for all drawables without explicit size (e.g. ShapeDrawable, GradientDrawable etc)?

[vinc3m1]

I've added a generic upstream in RoundedImageView that implements basic support for all drawables without explicit size. Please help test before I push out the next release: vinc3m1/RoundedImageView#30

FYI RoundedImageView has had support for circle images for a long time now through its is_oval param, in addition to a many more features...

[hdodenhof]

I actually doubt that the approach of just using fixed dimensions works well with drawables other than ColorDrawables, that's why I restricted it for now.

I'll try to look into this over the next couple days.

[vinc3m1]

That's true, but other drawables with effects based on dimensions should not be returning -1 in getInstrinsicHeight or getInstrinsicWidth either. Also more complex custom drawables that require multiple drawing passes cannot benefit from the optimization that this library uses, specifically the use of a BitmapShader.