Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8 #9

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Fix #8 #9

merged 3 commits into from
Jun 16, 2020

Conversation

vitorduarte
Copy link
Contributor

No description provided.

@hdorgeval
Copy link
Owner

Hi @vitorduarte , thank you for your contribution. I was wondering if it would be even simpler to remove the npm run report from the test script?

@vitorduarte
Copy link
Contributor Author

vitorduarte commented Jun 10, 2020

Hello @hdorgeval, I agree with you. Using the template I noticed that every time that I execute a test, a new browser tab opened, this is a little annoying. Maybe has a flag in report to change it, but decouple the npm report from test would be better.

We just need to make clear that before to run the report, it will be necessary to run the test. Or just add the npm test to npm report

@hdorgeval
Copy link
Owner

Hi @vitorduarte, feel free to remove the npm run report from the test script.

I will update the documentation on my side if you want :)

Thanks!

@hdorgeval hdorgeval merged commit af8a413 into hdorgeval:master Jun 16, 2020
@hdorgeval
Copy link
Owner

Hi @vitorduarte, thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants