Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional area-weighting in xskillscore metrics #1

Closed
hdrake opened this issue Oct 16, 2019 · 1 comment
Closed

Implement optional area-weighting in xskillscore metrics #1

hdrake opened this issue Oct 16, 2019 · 1 comment
Assignees
Labels
help wanted Extra attention is needed

Comments

@hdrake
Copy link
Owner

hdrake commented Oct 16, 2019

Currently, the performance metrics implemented in xskillscore (https://github.com/raybellwaves/xskillscore/blob/master/xskillscore/core/deterministic.py) do not allow for weighting by grid cell area when calculating a global-mean skill metric (as is customary in the literature, e.g. Reichler et al. 2008 https://journals.ametsoc.org/doi/abs/10.1175/BAMS-89-3-303).

Step 1 (a simple hack): multiply fields by a grid-cell area field, calculate the skill metric, and divide by the global-mean grid cell area.

Step 2: submit a PR to xskillscore (https://github.com/raybellwaves/xskillscore/) to make this a supported feature.

@hdrake
Copy link
Owner Author

hdrake commented Oct 18, 2019

Now implemented in master branch #12

Will wait to close this issue until area-weighting has been merged into the master branch of xskillscore.

@hdrake hdrake closed this as completed Oct 18, 2019
@hdrake hdrake reopened this Oct 18, 2019
@hdrake hdrake removed the enhancement New feature or request label Oct 26, 2019
@hdrake hdrake closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants