Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to apply v1/List "resources" #805

Closed
joaquimrocha opened this issue Nov 8, 2022 · 6 comments
Closed

Allow to apply v1/List "resources" #805

joaquimrocha opened this issue Nov 8, 2022 · 6 comments
Labels
frontend Issues related to the frontend good first issue Good for newcomers
Milestone

Comments

@joaquimrocha
Copy link
Collaborator

Description

Users may want to apply lists of resources in the form of a v1/List kind but this is not a regular resource in K8s. See kubernetes/kubectl#837 .

Here is an example of such list: https://kubernetes.io/docs/concepts/policy/resource-quotas/#resource-quota-per-priorityclass

Impact

Headlamp doesn't allow this kind of list to be applied as its expecting only regular resources (with a kind and a metadata.name).
Moreover, the resources defined in the list will not get the namespace automatically added since we're checking for a regular resource.

Expected behavior

Headlamp allows to apply List kind objects, and adds the default namespace to any resources in the list that need it.

@joaquimrocha joaquimrocha added good first issue Good for newcomers frontend Issues related to the frontend labels Nov 8, 2022
@joaquimrocha joaquimrocha added this to the v0.14.0 milestone Nov 8, 2022
@siddhant1
Copy link

I can pick this up!

@joaquimrocha joaquimrocha modified the milestones: v0.14.0, v0.15.0 Nov 22, 2022
@joaquimrocha
Copy link
Collaborator Author

@siddhant1 , yes, please go ahead. It's probably better to do it after #809 is merged.

@joaquimrocha
Copy link
Collaborator Author

The #809 is merged now. @siddhant1 , do you still want to work on this?

@siddhant1
Copy link

Yes, can you pass me the setup instructions @joaquimrocha

@joaquimrocha
Copy link
Collaborator Author

@siddhant1 , please check the intructions at https://kinvolk.github.io/headlamp/docs/latest/development/
Let us know if you run into problems.

@joaquimrocha joaquimrocha modified the milestones: v0.15.0, v0.16.0 Jan 10, 2023
@ashu8912
Copy link
Member

This is fixed now with #909

@ashu8912 ashu8912 closed this as completed Feb 5, 2023
@joaquimrocha joaquimrocha modified the milestones: v0.16.0, v0.15.0 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants