Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the calendar and date wherever used #958

Open
ashu8912 opened this issue Feb 15, 2023 · 5 comments
Open

Align the calendar and date wherever used #958

ashu8912 opened this issue Feb 15, 2023 · 5 comments
Labels
frontend Issues related to the frontend good first issue Good for newcomers

Comments

@ashu8912
Copy link
Member

If you go to a timestamp that uses the date and calendar option to show a date you will see that the date and calendar are not properly aligned
Screenshot 2023-02-15 at 2 26 38 PM

The date and calendar should be correctly center aligned.

@ashu8912 ashu8912 added frontend Issues related to the frontend good first issue Good for newcomers labels Feb 15, 2023
@thiyagarajan17
Copy link

Could you assign me for the fix.. would love to work on it

@joaquimrocha
Copy link
Collaborator

@thiyagarajan17 , this is already assigned to a member of our team.
We'd be very happy if you can work on another task. Let us know if there's anything not assigned that you would like to work on.

@joaquimrocha
Copy link
Collaborator

@thiyagarajan17 , we couldn't yet pick this issue up after all. We're happy to have you do it if you want, and we're here to help.

@egomezbpedro
Copy link
Contributor

egomezbpedro commented Aug 18, 2023

Hi team,

Could this perhaps be done in the Label file by modifying the following:

const useHoverInfoLabelStyles = makeStyles({
  display: {
-    display: 'inline-block',
+   display: 'flex',
+   alignItems: 'center',
+   justifyContent: 'flex-end'
  },
  noWrap: {
    whiteSpace: 'nowrap',
  },
  icon: {
    marginRight: '0.2rem',
    marginLeft: '0.2rem',
  },
});

Is also possible to use a child or possibly a sibling selector while keeping the inline-block as in:

const useHoverInfoLabelStyles = makeStyles({
  display: {
      display: 'inline-block',
+   "& svg": {
+      verticalAlign: 'middle'
+    },
  },
  noWrap: {
    whiteSpace: 'nowrap',
  },
  icon: {
    marginRight: '0.2rem',
    marginLeft: '0.2rem',
  },
});

Please let me know any feedback or other workaround suggestion or for this.

Thanks, Happy Friday :)

@egomezbpedro
Copy link
Contributor

egomezbpedro commented Aug 18, 2023

Even so the checking with the last code snippet it seems that the icon although gets centred inside the p tag is not that very well aligned with the text.

Screenshot 2023-08-18 at 12 55 15 Screenshot 2023-08-18 at 12 55 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues related to the frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants