Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What format are the codes in the --countries build argument? #195

Closed
wcedmisten opened this issue Dec 4, 2022 · 3 comments · Fixed by #196
Closed

What format are the codes in the --countries build argument? #195

wcedmisten opened this issue Dec 4, 2022 · 3 comments · Fixed by #196

Comments

@wcedmisten
Copy link
Contributor

https://github.com/headwaymaps/headway/blob/main/BUILD.md?plain=1#L54

Mentions including the countries used for the WOF import under the --countries arg.

https://github.com/pelias/wof-admin-lookup mentions 3-character country codes, but I wasn't able to tell if this should be used for the headway config as well, since the provided example is only 2 characters.

Is US a special case here? It would be great to clarify this explicitly in the docs.

Thanks!

@ellenhp
Copy link
Member

ellenhp commented Dec 4, 2022

Hi! That value is piped into the whosonfirst section of the pelias.json config via environment variable substitution. The parameter is documented here but the short answer is it looks like any two digit ISO 3166-1 country code, or a comma-delimited list of multiple two digit ISO 3166-1 country codes.

@wcedmisten
Copy link
Contributor Author

I looked in two different pelias repos, but not that one, whoops!

I put up a documentation PR that I think would be useful, but feel free to close it if you disagree. Thanks!

@ellenhp
Copy link
Member

ellenhp commented Dec 4, 2022

Looks useful to me but I'm not the maintainer of this project anymore so it'll be up to @michaelkirk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants