Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cards: card image: deviating behavior in the editor #501

Closed
flx-sta opened this issue Aug 13, 2020 · 4 comments
Closed

cards: card image: deviating behavior in the editor #501

flx-sta opened this issue Aug 13, 2020 · 4 comments
Assignees

Comments

@flx-sta
Copy link
Contributor

flx-sta commented Aug 13, 2020

kestrel-1/report-an-issue#9

  • It is possible to select a card by clicking on the title or text. By trying to click on a card image, you select the entire card container.
  • A click on the title or text allows direct editing and the editor jumps to the place in the menu. A click on a card image will jump to the place of the card container and does not allow direct editing of the image.
@reusr1
Copy link
Contributor

reusr1 commented Aug 13, 2020

I think the big question here is what we really would want to happen. should we bring full inline editing to images as well and rethink that part or only support click an image and focus the field? What happens when we click in the padding of a card outside of an editable?

@ehdatheadwire
Copy link
Collaborator

@Felix-Puetz I was going to close this OG issue and relocate to here: peregrine-cms/enhancements#19 but it looks like you might be working on it or want to work on it? Could you let me know when you get a chance? I don't want to move it if it's in progress :). Thanks!

@flx-sta
Copy link
Contributor Author

flx-sta commented Mar 5, 2021

@ehdatheadwire not working on it. Go ahead 👍

@ehdatheadwire
Copy link
Collaborator

Fab thanks, @Felix-Puetz. Closing OG issue and relocating to: peregrine-cms/enhancements#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants