Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code-style standard (maybe only JS code for now) #532

Closed
flx-sta opened this issue Aug 31, 2020 · 2 comments
Closed

code-style standard (maybe only JS code for now) #532

flx-sta opened this issue Aug 31, 2020 · 2 comments
Labels
feature javascript Pull requests that update Javascript code refactoring RFI request for input

Comments

@flx-sta
Copy link
Contributor

flx-sta commented Aug 31, 2020

We should agree on a code-style standard.

At least for the javascript code.
@flx-sta flx-sta added feature javascript Pull requests that update Javascript code refactoring RFI request for input labels Aug 31, 2020
@flx-sta flx-sta pinned this issue Aug 31, 2020
@reusr1
Copy link
Contributor

reusr1 commented Aug 31, 2020

I agree we should agree on that (for front end code and backend code). But we really should do this in my opinion once we are fully merged into the develop-sling12 branch because right now a reformat of the codebase would make it nearly impossible to merge

@flx-sta flx-sta unpinned this issue Oct 23, 2020
@ehdatheadwire ehdatheadwire mentioned this issue Mar 5, 2021
Open
@ehdatheadwire
Copy link
Collaborator

Closing OG issue and relocating to: peregrine-cms/enhancements#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature javascript Pull requests that update Javascript code refactoring RFI request for input
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reusr1 @flx-sta @ehdatheadwire