Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter secondary items toggle and exclude from site map #617

Closed
GastonGonzalez opened this issue Oct 21, 2020 · 3 comments
Closed

Filter secondary items toggle and exclude from site map #617

GastonGonzalez opened this issue Oct 21, 2020 · 3 comments
Assignees

Comments

@GastonGonzalez
Copy link
Collaborator

The exclude from sitemap page property and filter secondary items should not be bound together. Exclude from sitemap should only be used to prevent a page from appearing in the sitemap. Instead, filter secondary items uses this field to hide pages from page navigation.

Use Case

  1. Create a skeleton page (i.e Blog with Recommendations)
  2. Set the exclude from sitemap property to true to prevent it from appearing in the sitemap.
  3. Create a page (p1) based on the skeleton page.

Observed Behavior
User is unable to see their page while navigating Pages.

Expected Behavior
User can see their new page.

Work Around

  1. Toggle the secondary items filter
  2. Your page (p1) should be visible.
  3. Set exclude from sitemap = false

This issue is not critical, but IMHO, breaks the flow in the creative editing process.

@reusr1
Copy link
Contributor

reusr1 commented Oct 21, 2020

@GastonGonzalez makes sense to decouple the two use cases - unfortunately we do not have a overall way right now to filter out the supporting files in the folder as well as the supporting directories like errors, css and js - the solution therefore has to include a fix for these folders as well

@GastonGonzalez
Copy link
Collaborator Author

Sounds fair, @reusr1. Thanks for the speedy response. This one can wait, but thought I would raise it while creating content this morning as it took me out of the creative writing process. Do we have a design ticket for handling supporting files?

@ehdatheadwire
Copy link
Collaborator

Closing OG issue and relocating to: peregrine-cms/enhancements#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants