Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards: Cards per row lets you exceed max value #42

Closed
bkheadwire opened this issue Jul 10, 2019 · 4 comments
Closed

Cards: Cards per row lets you exceed max value #42

bkheadwire opened this issue Jul 10, 2019 · 4 comments
Assignees
Projects

Comments

@bkheadwire
Copy link
Collaborator

Steps to reproduce:

  1. Add cards component
  2. Set the cards per row value to 7

Expected result:
Editor should stop you from choosing an out-of-range value

Actual result:
Out-of-range value is allowed and component turns into one big stretched card

@reusr1 reusr1 added this to triage in release via automation Jul 12, 2019
@dna113p dna113p moved this from triage to in progress in release Jul 16, 2019
@dna113p
Copy link
Collaborator

dna113p commented Jul 16, 2019

This is an issue that will have to be at least partially fixed in peregrine, as we aren't validating any of our inputs.

@dna113p dna113p moved this from in progress to done in release Jul 16, 2019
@dna113p dna113p moved this from done to Backlog in release Jul 16, 2019
@dna113p dna113p moved this from Backlog to in progress in release Jul 17, 2019
@dna113p dna113p moved this from in progress to verify in release Jul 18, 2019
@dna113p dna113p moved this from verify to done in release Jul 18, 2019
@dna113p dna113p moved this from done to verify in release Jul 18, 2019
@dna113p
Copy link
Collaborator

dna113p commented Jul 18, 2019

Changed the number input to a range slider

@bkheadwire
Copy link
Collaborator Author

The slider does the trick for this particular issue. There is one slightly awkward thing I'm seeing now which is that when the slider is all the way to the right, a horizontal scroll bar shows up on the editor panel.

01-sliderbar

@reusr1
Copy link
Contributor

reusr1 commented Jul 22, 2019

@bkheadwire is this the case for all sliders? It is probably better to open a peregrine issue for this and close this issue out

release automation moved this from verify to done Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
release
  
done
Development

No branches or pull requests

3 participants