Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: change category badge status to partially down #251

Closed
BioTheWolff opened this issue May 9, 2019 · 3 comments
Closed

Comments

@BioTheWolff
Copy link

BioTheWolff commented May 9, 2019

I am doing a status page and made a check fail for test purposes. I saw that if one check is down, all the categories it belongs to are noted "down". Could we add a orange-ish color and a "Partially Down" state if the category has up checks and down checks ?

@BioTheWolff BioTheWolff changed the title Feature Request: change badge status to partially down Feature Request: change category badge status to partially down May 9, 2019
@cuu508
Copy link
Member

cuu508 commented May 14, 2019

The orange color is currently used to indicate the "in grace period" status. The rules are:

  • If any matching check is down, the badge is red
  • Otherwise, if any matching check is in the grace period, the badge is orange
  • Otherwise the badge is green

The badges have SVG and JSON versions:

image

We cannot easily change the behaviour of the SVG badges because people are already relying on their current behaviour. We can, however, add more fields in the JSON ones. Say, instead of returning

{"status": "down"}

return a few more fields:

{"status": "down", "up": 15, "grace": 0, "down": 1}

On the status page side you could then fetch the JSON and format it as a badge or a dashboard widget locally. How does that sound?

@BioTheWolff
Copy link
Author

Sounds really great ! In addition to allowing the users to get more informations, you give numbers that can be displayed too ! I like the idea, it is totally the answer i expected. Thanks :p
Tell me if you want to implement it right now or later, i don't care much about the date :)

@cuu508 cuu508 closed this as completed in 1b948f4 May 15, 2019
@cuu508
Copy link
Member

cuu508 commented May 15, 2019

@BioTheWolff I've now deployed this change. Feel free to check it out when you get a chance.

I decided to go with this format:

{"status": "down", "total": 16, "grace": 0, "down": 1}

I used "total" instead of "up", because checks can also be in "new" and "paused" states – it would be inaccurate to count them as "up".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants