Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schedules such as every 85 minutes #281

Closed
baragona opened this issue Aug 27, 2019 · 6 comments
Closed

Support schedules such as every 85 minutes #281

baragona opened this issue Aug 27, 2019 · 6 comments
Labels

Comments

@baragona
Copy link

We can set schedules with granularity every minute, up to 60 minutes, then the granularity is 1 hour... So we can't set schedules such as every 80 minutes.

@jesse-holden
Copy link

You can already achieve granularity by creating/updating checks via API, you can supply the schedules with intervals accurate to the second.

@cuu508
Copy link
Member

cuu508 commented Feb 12, 2021

UI suggestions from @peternlewis on twitter:

maybe just something between the sliders and cron that just lets me enter the number of days/hours for each as numbers. Or maybe in the slider window, a text field, so changing the slider changes the number, but changing the number also works (and changes the slider).

@cuu508 cuu508 added the feature label Aug 27, 2021
@cuu508
Copy link
Member

cuu508 commented Nov 3, 2021

I'm experimenting with UI ideas and considering this one:

image

Next to the "Period" label there is now an input box. Moving the slider updates the value in the input box. Editing text in the input box updates the slider. The slider range is extended to 365 days so the slider can display something approximately correct when the user enters "60 days" or "90 days". It is not explained in the UI, but the text box would accept three formats:

  • "[number] minutes"
  • "[number] hours"
  • "[number] days"

"60 days" and "86400 minutes" would be equivalent inputs.

PS. In the screenshot, the "Grace Time" section is not updated yet. It would be updated to look and work the same as the "Period" section.

@cuu508
Copy link
Member

cuu508 commented Nov 3, 2021

One part I'm not sure about is the "[number] minutes|hours|days" special syntax. It would need to be documented somewhere, there would be corner cases, and user errors. A more structured alternative:

image

The user can enter a number, and select minutes / hours / days from the dropdown. This would prevent invalid inputs like "2 months" but would still allow "85 minutes" or "60 days".

@baragona
Copy link
Author

baragona commented Nov 4, 2021

I like the dropdown a lot.

@cuu508 cuu508 closed this as completed in e0d2f36 Nov 4, 2021
@cuu508
Copy link
Member

cuu508 commented Nov 4, 2021

I've implemented the initial version, also available on the hosted service now.

For the minutes / hours / days selector I went with the standard <select> element. Better accessibility and cleaner code compared to bootstrap dropdown.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants