Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: allow specifying enabled integrations by name #440

Closed
cuu508 opened this issue Oct 7, 2020 · 0 comments
Closed

API: allow specifying enabled integrations by name #440

cuu508 opened this issue Oct 7, 2020 · 0 comments

Comments

@cuu508
Copy link
Member

cuu508 commented Oct 7, 2020

Suggested in #376:

Another way of having less API calls is if you added a parameter to let you pass in the channels by name rather than by id (it would assume channel names are unique) - that way I could skip the extra API call to get the channel id from the name :)

A few decisions:

  • what to do when API client uses a channel name that does not exist?
  • what to do when API client uses a non-unique channel name?

Could be strict or lenient here. I'm leaning towards strict to avoid subtle configuration mistakes: whenever a channel name in client's payload does not have precisely one match in the database, return HTTP 400 and a descriptive error message.

@cuu508 cuu508 closed this as completed in 0e77064 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant