Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'received via the /fail endpoint' to include the status code? #455

Closed
wlupton opened this issue Nov 25, 2020 · 2 comments
Closed

'received via the /fail endpoint' to include the status code? #455

wlupton opened this issue Nov 25, 2020 · 2 comments

Comments

@wlupton
Copy link

wlupton commented Nov 25, 2020

I'm wondering whether log item details (in the GUI) could include the status code. Currently I believe we see this:

Screenshot 2020-11-25 at 13 04 23

regardless of whether the /fail or /<status> endpoint was used.

@cuu508
Copy link
Member

cuu508 commented Nov 25, 2020

Healthchecks currently doesn't tack the status code (and so cannot display it), but this is something it could and probably should do.
Storing one extra single-byte field per ping should be fine.

@cuu508
Copy link
Member

cuu508 commented Nov 27, 2020

Once we start tracking exit status in the database, we can show it in the "ping details" dialog:

image

And in the event log:

image

In the log, there's no explanation for what a number in a red badge means. But I think a technical user would be able to guess, especially the person who set it up.

@cuu508 cuu508 closed this as completed in 617bd92 Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants