Add browser support #6

pwnall · 2016-04-06T03:47:55Z

No description provided.

coveralls · 2016-04-06T04:27:01Z

Coverage decreased (-4.3%) to 82.171% when pulling 95a87c1 on pwnall:browser into 7b39f95 on heap:master.

pwnall · 2016-04-06T04:48:02Z

Coverage decreased because of the browser-specific code. ¯_(ツ)_/¯

jeffling · 2016-04-06T09:07:55Z

test/benchmark_test.js

-    code();
+var benchmark = null;
+
+if (typeof(process) !== "undefined" && typeof(process.hrtime) === "function") {


i like doing typeof((process || {}).hrtime) === "function" as it's more declarative, but consider this a non-blocking nit

But process isn't defined in the browser, so this would crash 😢

I can use this pattern to simplify the CSPRNG engine detection though. Thank you!

I used the pattern that you suggested here:
https://github.com/heap/cryptohat/pull/6/files#diff-168726dbe96b3ce427e7fedce31bb0bcR93

pwnall · 2016-04-06T21:03:38Z

I addressed the feedback and extended the README with browser testing instructions. PTAL.

coveralls · 2016-04-06T21:09:01Z

Coverage decreased (-4.3%) to 82.171% when pulling 453cb92 on pwnall:browser into 7b39f95 on heap:master.

pwnall · 2016-04-09T09:27:37Z

@jeffling ping? Can you please take another look at this?

pwnall assigned jeffling Apr 6, 2016

jeffling reviewed Apr 6, 2016
View reviewed changes

Browser support.

453cb92

pwnall force-pushed the browser branch from 95a87c1 to 453cb92 Compare April 6, 2016 21:00

jeffling merged commit 9da0338 into heap-legacy:master Apr 9, 2016

Provide feedback