update_with_password does not check to see if new password and confirmation are the same

[mdoroudi]

update_with_password doesn't check if the new password and confirmation matches so it just accepts the new password regardless.
I'm already working on it so I can just submit the fix.

[josevalim]

the validation will only happen if you have validatable included, it is not part of update_with_password to validate new password and friends.

[joelcdoyle]

This is the exact issue I am having. Even if validatable is included, update_with_password does not return false if password and password_confirmation are different or if password_confirmation is nil.

[joelcdoyle]

@mdoroudi I would like to see your fix.

[josevalim]

@joelcdoyle I see now. I will reopen the other issue, it is indeed a bug.

[joelcdoyle]

Yey! I helped. Thanks, @josevalim