Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should probably not display unlock link for :time strategy #204

Closed
marcio497 opened this issue Apr 14, 2010 · 4 comments
Closed

Should probably not display unlock link for :time strategy #204

marcio497 opened this issue Apr 14, 2010 · 4 comments

Comments

@marcio497
Copy link

A link on login page to unlock account leads to an error when :time is used as unlock strategy. I modified views/shared/_devise_links.erb to omit the link in such cases (I hope thats the correct place).

http://gist.github.com/365873

@carlosantoniodasilva
Copy link
Member

It seems reasonable to not show the unlock link, but I think we should just show it if and only if you have enabled :email, and not if you don't enable :time. It's due to the possibility of having both :email and :time enabled.
What do you think?

@marcio497
Copy link
Author

You are right, I completely forgot its possible to set :both.

@josevalim
Copy link
Contributor

Can you please create a new patch then but using git format-patch or forking Devise and sending us the commit link?

@josevalim
Copy link
Contributor

Do not show unlock link unless strategy is e-mail. Closed by 731f156.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants