Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 3 RC: SimpleForm::FormBuilder#association calling undefined method 'returning' #31

Closed
iabbott opened this issue Jul 27, 2010 · 4 comments

Comments

@iabbott
Copy link

iabbott commented Jul 27, 2010

Rails 3 RC has without warning or fallback support dropped support for Object#returning. It's been replaced by Object#tap. No deprecation notices, just a quick comment in the CHANGELOG (one of many Beta to RC changes that has been sudden without any form of migration; e.g. config.autoload_paths....)

As a result, any f.association calls throw ActionView::Template::Error

@josevalim
Copy link
Contributor

Hi, my name is José Valim and I'm from Rails Core team. :)

I will fix SimpleForm, but about Rails, until yesterday, we had a beta version. This means we are still allowed to do changes, big or small. Notice that we added however, deprecations to 2-3-stable, which is the path most people will follow (from 2-3-stable to Rails 3 final).

The Rakefile changes and config.autoload_paths were added to the CHANGELOG, but not returning one. I will fix it as well, thanks.

@josevalim
Copy link
Contributor

Ops, it seems that all three changes are listed in the CHANGELOG, so nothing to fix there. Now fixing simple_form. :)

@iabbott
Copy link
Author

iabbott commented Jul 27, 2010

Sorry about that, don't mean to grumble so much - the Rails team is doing a lot of good work and it's nice to see an RC out. My own fault for hopping on board early, but DHH did say it was time to start migrating :D Here's hoping final release is sooner rather than later as the changes from Rails 2 are great so far.

@josevalim
Copy link
Contributor

Ok! Rest assured that such changes must not happen from now on.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants