Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate bootstrap (and upcoming zurb) integration setup #544

Closed
carlosantoniodasilva opened this issue Apr 22, 2012 · 3 comments · Fixed by #548
Closed

Separate bootstrap (and upcoming zurb) integration setup #544

carlosantoniodasilva opened this issue Apr 22, 2012 · 3 comments · Fixed by #548
Milestone

Comments

@carlosantoniodasilva
Copy link
Member

We want to remove all if/else conditions in SimpleForm initializer template, mostly related to bootstrap and the upcoming zurb foundation integrations, so there are two possibilities:

  • Move them to the bottom of SimpleForm initializer, as a separate configure block, to override the defaults.
  • Move them to a separate file each, for instance simple_form_bootstrap.rb, to be copied to app initializers when running the install generator.

All this will allow us to keep better defaults in the initializer.

@nashby
Copy link
Collaborator

nashby commented Apr 23, 2012

I think the second one is better and I can work on it. What do others think?

@rafaelfranca
Copy link
Collaborator

@nashby 👍

@josevalim
Copy link
Contributor

A separate file seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants