Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile not valid error while installing with bundler via git #7

Closed
jo opened this issue Mar 1, 2010 · 4 comments
Closed

Gemfile not valid error while installing with bundler via git #7

jo opened this issue Mar 1, 2010 · 4 comments

Comments

@jo
Copy link
Contributor

jo commented Mar 1, 2010

i get the following error:

simple_form at /home/jo/.bundle/ruby/1.8/bundler/gems/simple_form-917206bb6c5458ef73c7b90fe49bfa5e4cbdde9d-master did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  ["test/support/country_select/init.rb", "test/support/country_select/install.rb", "test/support/country_select/lib/country_select.rb", "test/support/country_select/uninstall.rb"] are not files

However, when I run
rake gemspec:validate
it tell me:
simple_form.gemspec is valid.

Greetings
Johannes

@jo
Copy link
Contributor Author

jo commented Mar 1, 2010

btw: with Ruby 1.9 this issue does not appear.

@josevalim
Copy link
Contributor

Probably because those are vendored with gitsubmodule. Please provide a patch where you do something like this in our rakefile: s.text_files.exclude("test/support/country_select")

@jo
Copy link
Contributor Author

jo commented Mar 1, 2010

thanx!

My fork at http://github.com/jo/simple_form includes that patch, which works well.

@josevalim
Copy link
Contributor

Awesome, applied! :D

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants