We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When creating or editing a GCS Source Storage, disabling the Use pre-signed URLs does not work.
Use pre-signed URLs
To Reproduce
Project
Setting
Cloud Storage
Add Source Storage
GCS
Edit
Expected behavior Use pre-signed URLs should be disabled.
Screenshots
Environment (please complete the following information):
1.0.2
Additional context Value sent to backend when form is submitted with Use pre-signed URLs disabled:
{ "project": "3", "bucket": "test", "regex_filter": ".*", "use_blob_urls": true, "presign_ttl": "1" }
Value sent to backend when with the Use-pre-signed URLs enabled:
Use-pre-signed URLs
{ "project": "3", "bucket": "test", "regex_filter": ".*", "use_blob_urls": true, "presign": "true", "presign_ttl": "1" }
Seems like when the toggle button is disabled "presign": "false" is not sent. Might be a frontend regression.
"presign": "false"
The text was updated successfully, but these errors were encountered:
I just tried this with 1.1.0 and issue still persists.
1.1.0
Sorry, something went wrong.
makseq
Successfully merging a pull request may close this issue.
When creating or editing a GCS Source Storage, disabling the
Use pre-signed URLs
does not work.To Reproduce
Project
->Setting
->Cloud Storage
->Add Source Storage
->GCS
Use pre-signed URLs
toggle button.Edit
.Use pre-signed URLs
is enabled.Expected behavior
Use pre-signed URLs
should be disabled.Screenshots
Environment (please complete the following information):
1.0.2
Additional context
Value sent to backend when form is submitted with
Use pre-signed URLs
disabled:Value sent to backend when with the
Use-pre-signed URLs
enabled:Seems like when the toggle button is disabled
"presign": "false"
is not sent. Might be a frontend regression.The text was updated successfully, but these errors were encountered: