Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not disable Use pre-signed URLs for GCS Source Storage #1054

Closed
nader-bitstrapped-com opened this issue Jun 13, 2021 · 1 comment · Fixed by #1181
Closed

Can not disable Use pre-signed URLs for GCS Source Storage #1054

nader-bitstrapped-com opened this issue Jun 13, 2021 · 1 comment · Fixed by #1181
Assignees
Labels
problem bug or something isn't working

Comments

@nader-bitstrapped-com
Copy link

nader-bitstrapped-com commented Jun 13, 2021

When creating or editing a GCS Source Storage, disabling the Use pre-signed URLs does not work.

To Reproduce

  1. Go to Project -> Setting -> Cloud Storage -> Add Source Storage -> GCS
  2. Fill the form and disable the Use pre-signed URLs toggle button.
  3. Save the form.
  4. Click on the three dots and Edit.
  5. Use pre-signed URLs is enabled.

Expected behavior
Use pre-signed URLs should be disabled.

Screenshots

add

edit

Environment (please complete the following information):

  • Docker
  • Label Studio Version 1.0.2

Additional context
Value sent to backend when form is submitted with Use pre-signed URLs disabled:

{
  "project": "3",
  "bucket": "test",
  "regex_filter": ".*",
  "use_blob_urls": true,
  "presign_ttl": "1"
}

Value sent to backend when with the Use-pre-signed URLs enabled:

{
  "project": "3",
  "bucket": "test",
  "regex_filter": ".*",
  "use_blob_urls": true,
  "presign": "true",
  "presign_ttl": "1"
}

Seems like when the toggle button is disabled "presign": "false" is not sent. Might be a frontend regression.

@makseq makseq added this to the Label Studio 1.1 milestone Jun 14, 2021
@makseq makseq added the problem bug or something isn't working label Jun 14, 2021
@nader-bitstrapped-com
Copy link
Author

I just tried this with 1.1.0 and issue still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem bug or something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants