Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Segmentation/Brush Tool does not work as expected, Scissor/Multiple brush-strokes #492

Closed
tristanratz opened this issue Nov 17, 2020 · 7 comments
Assignees
Labels
problem bug or something isn't working

Comments

@tristanratz
Copy link

Describe the bug

The scissortool in brush segmentation does not erase the whole brush stroke but only makes it lighter. The opacity of the stroke gets reduced.

Furthermore another brushstroke/scissorstroke can only be started from an area where I never have drawn with the scissortool or a brush. One has always to drag/start the tools outside of the "used" areas to work.

To Reproduce

  1. Create a config.xml which uses the brush image segmentation
  2. Draw a brushstroke
  3. Try to erase the drawn area or to draw a new stroke in the used area - it will not work

Expected behavior

It should be possible to start new brush-/scissorstrokes from anywhere inside the picture. Furthermore the scissortool should erase the brushes to zero opacity.

Screenshots

After erasing with scissor (still fragments of the brushtool):
image

Environment (please complete the following information):

  • OS: any
  • Label Studio Version [0.8.0]
@tristanratz tristanratz added the problem bug or something isn't working label Nov 17, 2020
@makseq
Copy link
Member

makseq commented Nov 17, 2020

Thank you for your report, we've created a ticket about this bug.

@davidblom603
Copy link

Noticed this problem too.

@faizan170
Copy link

Same issue, any update?

@tcapelle
Copy link

tcapelle commented Nov 23, 2020

Did you manage to make it work?
I have a somewhat related issue, the pixel output should be solid (not different opacity levels). For each label, one gray value. I get soft borders. Maybe it is related.
image

Here values should be either 128 or 192, but not in-between.

@makseq
Copy link
Member

makseq commented Nov 23, 2020

@faizan170 We are working on it.

@tcapelle Why can't you apply a simple thresholding to this array? For example:

img[img > 0] = 1
mask = img.astype(np.bool)

@tcapelle
Copy link

tcapelle commented Nov 24, 2020

Thanks you for looking at this, i am doing this right now, but it is far from optimal.

  • The brush should be hard, and paint (segment) only the given value.
  • Have not been able to find where to set this value. (e.g. Label Plane - > 128 value on mask, for instance.)

@nicholasrq
Copy link
Member

This issue was fixed and available since LS 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem bug or something isn't working
Projects
Label Studio Roadmap
Awaiting triage
Development

No branches or pull requests

7 participants