-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DEV-1904: Fixed source storage duplicating tasks when double click Sync button #2915
Conversation
✅ Linked to Bug DEV-1904 · Source storage duplicated tasks when double click Sync button |
Codecov ReportBase: 77.42% // Head: 77.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2915 +/- ##
===========================================
- Coverage 77.42% 77.36% -0.07%
===========================================
Files 146 146
Lines 10775 10791 +16
===========================================
+ Hits 8343 8348 +5
- Misses 2432 2443 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I would add simple test here where sync is called twice. |
Description of the proposed changes
Users are being able to click sync button as many times as they want.
In order to avoid running multiple sync jobs at the same time, as a first approach, we have decided to implement a method which checks if there is a sync job already in the queue for that specific project before start the sync.
Jira Ticket
https://heartex.atlassian.net/browse/DEV-1904